Guitar practice advice?

Well i've been playing guitar for about two years now and i'm at the point where i've begun to question my own abilities. One of the things I would like to ask everyone is: I never really properly play songs all the way through. If there is a riff in a song I really like I'll learn it but I always prefer to create my own riffs. Is this bad?